Adium

Ticket #11585 (closed patch: fixed)

Opened 14 months ago

Last modified 14 months ago

Adium does not deactivate the tune status

Reported by: tomgr Owned by: nobody
Milestone: Adium 1.3.3 Component: Adium Core
Version: Severity: minor
Keywords: Cc:
Patch Status: Accepted

Description

Adium does not deactivate libpurple's tune status when no song is playing which leads to an empty music status being set (consisting of a musical note and a space) rather than no status being set at all.

The attached patch fixes this and was tested with MSN and GTalk. Deactivating the "tune" status is consistent with music plugins for Pidgin.

Attachments

TuneStatus.diff (3.1 KB) - added by tomgr 14 months ago.

Change History

follow-up: ↓ 2   Changed 14 months ago by Robby

  • patch_status changed from Initially Included to Needs Dev Review

Hey tomgr, thanks a lot for your patch! :)
How does this issue relate to the one described in #10490?

Changed 14 months ago by tomgr

in reply to: ↑ 1   Changed 14 months ago by tomgr

Replying to Robby:

Hey tomgr, thanks a lot for your patch! :)
How does this issue relate to the one described in #10490?

Hi! It's not the same issue, but I've updated the patch to fix that issue too; though I should add that I've not tested that it does fix that issue, but it should!

follow-up: ↓ 4   Changed 14 months ago by Robby

  • priority changed from normal to low
  • severity changed from normal to minor
  • milestone set to Adium 1.3.3

Thanks a lot! Let's see if we can squeeze this into 1.3.3. :)

in reply to: ↑ 3   Changed 14 months ago by tomgr

Replying to Robby:

Thanks a lot! Let's see if we can squeeze this into 1.3.3. :)

Thanks Robby!

  Changed 14 months ago by evands

  • status changed from new to closed
  • resolution set to fixed

(In [25790]) Applied and modified a patch from tomgr which fixes #11585, so that we now properly hide the iTunes now playing information if the preference for an account to broadcast is toggled off and don't show blank song info when no song is playing. Thanks, tomgr!

Fixes #11585. I'm pretty sure this fixes #10490 though I would appreciate confirmation of that.

  Changed 14 months ago by evands

(In [25791]) Merged [25790]: Applied and modified a patch from tomgr which fixes #11585, so that we now properly hide the iTunes now playing information if the preference for an account to broadcast is toggled off and don't show blank song info when no song is playing. Thanks, tomgr!

Fixes #11585. I'm pretty sure this fixes #10490 though I would appreciate confirmation of that.

  Changed 14 months ago by Robby

  • patch_status changed from Needs Dev Review to Accepted

  Changed 14 months ago by tomgr

As a small note: this won't work properly until  http://developer.pidgin.im/ticket/8162 is fixed - it seems that statuses which are not saveable are being saved, so if you're listening to a song, accounts.xml is written out, then you close adium, then close iTunes and then re-open adium it will still say you're listening to the old song. This seems to be a libpurple bug though since the tune status is not supposed to be saved.

  Changed 14 months ago by Robby

Thanks, tomgr. :)

Note: See TracTickets for help on using tickets.