Ticket #11585 (closed patch: fixed)
Adium does not deactivate the tune status
| Reported by: | tomgr | Owned by: | nobody |
|---|---|---|---|
| Milestone: | Adium 1.3.3 | Component: | Adium Core |
| Version: | Severity: | minor | |
| Keywords: | Cc: | ||
| Patch Status: | Accepted |
Description
Adium does not deactivate libpurple's tune status when no song is playing which leads to an empty music status being set (consisting of a musical note and a space) rather than no status being set at all.
The attached patch fixes this and was tested with MSN and GTalk. Deactivating the "tune" status is consistent with music plugins for Pidgin.
Attachments
-
TuneStatus.diff
(3.1 KB) -
added by tomgr 3 years ago.
Change History
comment:1 follow-up: ↓ 2 Changed 3 years ago by Robby
- Patch Status changed from Initially Included to Needs Dev Review
comment:3 follow-up: ↓ 4 Changed 3 years ago by Robby
- priority changed from normal to low
- Severity changed from normal to minor
- Milestone set to Adium 1.3.3
Thanks a lot! Let's see if we can squeeze this into 1.3.3. :)
comment:5 Changed 3 years ago by evands
- Status changed from new to closed
- Resolution set to fixed
(In [25790]) Applied and modified a patch from tomgr which fixes #11585, so that we now properly hide the iTunes now playing information if the preference for an account to broadcast is toggled off and don't show blank song info when no song is playing. Thanks, tomgr!
Fixes #11585. I'm pretty sure this fixes #10490 though I would appreciate confirmation of that.
comment:6 Changed 3 years ago by evands
(In [25791]) Merged [25790]: Applied and modified a patch from tomgr which fixes #11585, so that we now properly hide the iTunes now playing information if the preference for an account to broadcast is toggled off and don't show blank song info when no song is playing. Thanks, tomgr!
Fixes #11585. I'm pretty sure this fixes #10490 though I would appreciate confirmation of that.
comment:8 Changed 3 years ago by tomgr
As a small note: this won't work properly until http://developer.pidgin.im/ticket/8162 is fixed - it seems that statuses which are not saveable are being saved, so if you're listening to a song, accounts.xml is written out, then you close adium, then close iTunes and then re-open adium it will still say you're listening to the old song. This seems to be a libpurple bug though since the tune status is not supposed to be saved.
Hey tomgr, thanks a lot for your patch! :)
How does this issue relate to the one described in #10490?