Adium

Ticket #10996 (closed defect: fixed)

Opened 10 months ago

Last modified 10 months ago

Wrong string used for emoticons, AdiumyEmoticonSet

Reported by: acollign Owned by: nobody
Milestone: Adium 1.3.2 Component: Xtras
Version: Severity: normal
Keywords: Cc: feedback@…
Patch Status: Accepted

Description

A mistake has been made in the Emoticons.plist file of the AdiumyEmoticonSet.

String entry of (Name key of) wub.png key is set to 'Kiss' instead of 'Lips are Sealed' or something like that. As a consequence, the name of the wub.png in emoticons list is set to Kiss (see the attached pic).

My 2cts

--- /Volumes/Home/acollign/Temp/adium/Resources/Emoticons/Adiumy.AdiumEmoticonset/Emoticons.plist	2008-09-04 18:29:21.000000000 +0200
+++ /Volumes/Home/acollign/Desktop/Emoticons.plist	2008-09-08 11:29:30.000000000 +0200
@@ -120,7 +120,7 @@
 				<string>:X</string>
 			</array>
 			<key>Name</key>
-			<string>Kiss</string>
+			<string>Lips are Sealed</string>
 		</dict>
 		<key>money.png</key>
 		<dict>

Attachments

wrong_label-lips_are_sealed.png (41.1 KB) - added by acollign 10 months ago.
adiumy.2.diff (406 bytes) - added by acollign 10 months ago.
patch

Change History

Changed 10 months ago by acollign

Changed 10 months ago by Robby

  • milestone set to Adium 1.3.2

Changed 10 months ago by mathuaerknedam

  • cc feedback@… added
  • patch_status changed from None to Needs Dev Review
  • component changed from Adium Core to Xtras

Here's a patch.

Changed 10 months ago by acollign

patch

Changed 10 months ago by acollign

Sorry mathuaerknedam, but you're wrong. Your patch changes the string of the correct smiley, have a look to the first line (<string>:*</string>).

I copy the patch given in the description to the file adiumy.2.diff

Changed 10 months ago by mathuaerknedam

Oops, you're right! I'll delete my patch.

Changed 10 months ago by evands

  • status changed from new to closed
  • resolution set to fixed

(In [25165]) Patch from acollign to fix the 'Lips Are Sealed' emoticon in the Adiumy set to be named properly. Fixes #10996

Changed 10 months ago by evands

(In [25166]) Merged [25165]: Patch from acollign to fix the 'Lips Are Sealed' emoticon in the Adiumy set to be named properly. Fixes #10996

Changed 10 months ago by Robby

  • patch_status changed from Needs Dev Review to Accepted
Note: See TracTickets for help on using tickets.