"id=insert" became required for status.html in Adium .80, breaking existing message styles

[mathuaerknedam]

When webkit message views were first introduced, an id=insert was not required (or functional) in status.html. If I download an old message style (say,  Sharp), and look at the chat preview in the messages prefpane, the second of the two status messages will be missing. It does not contain the [now] obligatory id=insert, but adding it makes the second status message appear and the preview now looks like the  xtras screenshot from 05/13/04. Sharp works as expected in Adium .77, but in .80 the consecutive status message disappears.

Just for reference,  this shows that the earliest version of Mockie (from 04/23/2004) didn't have id=insert either. It was added  here on 04/04/2005. (It's probable that nobody needs this, but I already looked it up, so here it is!)

I suspect that *many* old messages style are broken in this way. At the very least I'd guess that the 4 dozen or so that were released before Adium .80 came out. The Tutorial didn't include one (until a week ago!), so people were either building from instructions that didn't say to use it, or altering styles from a time when it wasn't even functional.

[jas8522]

So you opened this so that we could update the documentation and build this into that versioning system that Evan started?

I think I'll add message style versioning/compatibility updates to the 1.4 milestone...

[mathuaerknedam]

Well, I opened it because Evan asked me to open a ticket to document places where new versions of Adium break message styles that worked previously (within it's supported MessageViewVersion). The documentation from that far back is a bit sparse; I've not found any thing to indicate why the change was made without incrementing MVV. Perhaps it predates MVV?

[Robby]

If this is a regression why is it milestoned for 1.4, may I ask?

[jas8522]

Well... it's a regression from many many many versions ago, I don't see it being problematic to wait for one more major version. Plus there have been more than a couple message style issues that have been reported - why not put 'em all down for 1.4 and see if we can get that versioning system done at the same time. (Just a thought)

[mathuaerknedam]

Replying to jas8522:

...and see if we can get that versioning system done at the same time. (Just a thought)

There is already a versioning system in place, and I'm aware of David working on a big WKMV rewrite (MVV=5) for 1.5. Is there some other versioning system being considered?

[jas8522]

Oh maybe not... I thought there was a commit last week or so about having a 'basic versioning system' added in to 1.4svn but perhaps I misinterpreted...

[Robby]

Ah, ok.

[mathuaerknedam]

The only new versioning that I'm aware of is for plugins.

[Robby]

"Regressions shouldn't be tolerated". ;)

[Robby]

As it's a regression...

[evands]

Message styles have always been versioned. Unfortunately, the documentation didn't state this required tag until recently, so even recent versions can't be trusted.

[evands]

Sharp includes its own template.html. That template.html refers to the 'insert' div, but the style's status.html doesn't include one. Similarly, the old version of Mockie to which you link above did the same thing.

[evands]

(In [25544]) If a style doesn't include an 'insert' div but does let the default template.html be used by not overriding it, we now fall back on not treating the addition as a consecutive addition. This fixes a small number of cases of old styles which don't have an 'insert' div in their Status.html, but does not fix most of them since most override the template.html, as well. Refs #10921

[evands]

(In [25545]) For version 0 message styles with a custom template.html, such as Sharp, use APPEND_MESSAGE_WITH_SCROLL for consecutive status messages so they will be properly displayed. Fixes #10921

[evands]

(In [25546]) Merged [25544] and [25545]: For version 0 message styles with a custom template.html, such as Sharp, use APPEND_MESSAGE_WITH_SCROLL for consecutive status messages so they will be properly displayed. Fixes #10921