Adium

Ticket #10912 (closed defect: fixed)

Opened 19 months ago

Last modified 19 months ago

iChat transcript import fails for transcripts with inline images

Reported by: stewa Owned by: nobody
Milestone: Adium 1.3.1 Component: Adium Core
Version: 1.3svn Severity: normal
Keywords: Cc:
Patch Status: Rejected

Description

iChat transcripts with inline images can't be imported. The wizard either freezes or just continues without importing further transcripts. Out of my 2300 transcripts it ended up importing just 240 after removing the ones casing the wizard to freeze. Attached path fixes the crash issue. It still doesn't import any inline images bit that doesn't seem to be a supported feature?

Attachments

adium_ichat_import.diff (0.8 KB) - added by stewa 19 months ago.

Change History

Changed 19 months ago by stewa

Changed 19 months ago by Robby

  • patch_status changed from Initially Included to Needs Dev Review
  • milestone set to Adium 1.3.2

Thanks for your contribution! :)

Changed 19 months ago by evands

  • status changed from new to closed
  • resolution set to fixed

(In [25125]) We can now import the images in iChat Transcripts rather than throwing an exception. Thanks to stewa in #10912 for noting the location of the previous exception and providing a patch to workaround the issue; this commit instead fixes it. Fixes #10912.

Changed 19 months ago by evands

  • milestone changed from Adium 1.3.2 to Adium 1.3.1

Changed 19 months ago by evands

(In [25126]) Merged [25125]: We can now import the images in iChat Transcripts rather than throwing an exception. Thanks to stewa in #10912 for noting the location of the previous exception and providing a patch to workaround the issue; this commit instead fixes it. Fixes #10912.

Changed 19 months ago by Robby

  • patch_status changed from Needs Dev Review to Accepted

Changed 19 months ago by evands

  • patch_status changed from Accepted to Rejected

Changed 19 months ago by Robby

Oops. :D

Note: See TracTickets for help on using tickets.