xml parse error taking 1.3b7 online

[raeburn]

One of my accounts keeps going online, reporting a parse error, going offline, going back online, etc.

The debug log is pretty huge, but there are several parse errors reported; grep -i parse shows:

14:49:06: (Libpurple: jabber) XML parser error for JabberStream 0x0: Domain 1, code 5, level 3: Extra content at the end of the document
14:49:06: (Libpurple: jabber) XML parser error for JabberStream 0x0: Domain 1, code 5, level 3: Extra content at the end of the document
14:49:06: (Libpurple: jabber) XML parser error for JabberStream 0x0: Domain 1, code 100, level 1: xmlns: URI vcard-temp is not absolute
14:49:06: (Libpurple: jabber) jabber_iq_parse
14:49:06: (Libpurple: jabber) XML parser error for JabberStream 0x0: Domain 1, code 100, level 1: xmlns: URI vcard-temp is not absolute
14:49:06: (Libpurple: jabber) XML parser error for JabberStream 0x0: Domain 1, code 100, level 1: xmlns: URI vcard-temp is not absolute
14:49:06: (Libpurple: jabber) XML parser error for JabberStream 0x0: Domain 1, code 100, level 1: xmlns: URI vcard-temp is not absolute
14:49:06: (Libpurple: jabber) XML parser error for JabberStream 0x0: Domain 1, code 100, level 1: xmlns: URI vcard-temp is not absolute
14:49:06: (Libpurple: jabber) XML parser error for JabberStream 0x0: Domain 1, code 100, level 1: xmlns: URI vcard-temp is not absolute
14:49:06: (Libpurple: jabber) XML parser error for JabberStream 0x0: Domain 1, code 100, level 1: xmlns: URI vcard-temp is not absolute
14:49:06: (Libpurple: jabber) XML parser error for JabberStream 0x0: Domain 1, code 9, level 3: xmlParseCharRef: invalid xmlChar value 16
14:49:06: (Libpurple: jabber) xmlParseChunk returned error 9
14:49:06: (Libpurple: jabber) XML parser error for JabberStream 0x0: Domain 1, code 5, level 3: Extra content at the end of the document
14:49:06: (Libpurple: jabber) xmlParseChunk returned error 5
14:49:06: Connection Disconnected: gc=8ed3790 (XML Parse error)
14:49:06: <ESPurpleJabberAccount:5da6b90 11>:raeburn@mit.edu accountConnectionReportDisconnect: XML Parse error
14:49:06: (Libpurple: jabber) xmlParseChunk returned error 5
14:49:06: (Libpurple: jabber) xmlParseChunk returned error 5
14:49:06: (Libpurple: jabber) xmlParseChunk returned error 5
14:49:06: (Libpurple: jabber) xmlParseChunk returned error 5
14:49:06: (Libpurple: jabber) xmlParseChunk returned error 5
14:49:06: (Libpurple: jabber) xmlParseChunk returned error 5
14:49:06: (Libpurple: jabber) xmlParseChunk returned error 5
14:49:06: (Libpurple: jabber) xmlParseChunk returned error 5
14:49:06: (Libpurple: jabber) xmlParseChunk returned error 5
14:49:06: (Libpurple: jabber) xmlParseChunk returned error 5
14:49:06: (Libpurple: jabber) xmlParseChunk returned error 5
14:49:06: (Libpurple: jabber) xmlParseChunk returned error 5
14:49:06: (Libpurple: jabber) xmlParseChunk returned error 5
14:49:06: (Libpurple: jabber) xmlParseChunk returned error 5
14:49:06: <ESPurpleJabberAccount:5da6b90 11>:raeburn@mit.edu: Disconnected ("XML Parse error"): Automatically reconnecting in 5.000000 seconds (0 attempts performed)

The xmlParseChunk errors look like the only ones (with "parse" in the string) not present when I take all the other accounts online and leave this one disabled. The others seem to be non-fatal, and are also present when I take a copy of 1.3b3 online with this one problematic account.

Some samples of those errors from the log:

15:08:42: (Libpurple: jabber) Recv (ssl)(213): <iq type="result" to="raeburn@mit.edu/Adiumi985" id="purple50a00886" from="somebody@mit.edu/Adium"><query xmlns="jabber:iq:version"><name>Adium</name><version>&#16;BÔøΩ&#16; (libpurple 2.4.3)</version></query></iq>
15:08:42: (Libpurple: jabber) XML parser error for JabberStream 0x0: Domain 1, code 9, level 3: xmlParseCharRef: invalid xmlChar value 16
15:08:42: (Libpurple: jabber) xmlParseChunk returned error 9

15:08:42: (Libpurple: jabber) Recv (ssl)(391): <presence from="somebody1@gmail.com/gmail.E541E193" to="raeburn@mit.edu/Adiumi985"><show>away</show><priority>0</priority><caps:c xmlns:caps="http://jabber.org/protocol/caps" node="http://mail.google.com/xmpp/client/caps" ver="1.1" ext="pmuc-v1"></caps:c><status>Wow, embedded chat!</status><x xmlns="vcard-temp:x:update"><photo>57c7617952cf2ddc707153466a23da3976f2da10</photo></x></presence>
15:08:42: (Libpurple: jabber) xmlParseChunk returned error 5
15:08:42: (Libpurple: jabber) Recv (ssl)(203): <iq type="result" to="raeburn@mit.edu/Adiumi985" id="purple50a00879" from="somebody2@mit.edu/Adium"><query xmlns="jabber:iq:version"><name>Adium</name><version> (libpurple 2.5.0devel)</version></query></iq>
15:08:42: (Libpurple: jabber) xmlParseChunk returned error 5
15:08:42: (Libpurple: jabber) Recv (ssl)(344): <presence from="somebody1@gmail.com/somebody1/fE092FC9F" to="raeburn@mit.edu/Adiumi985"><priority>1</priority><c xmlns="http://jabber.org/protocol/caps" node="http://pidgin.im/caps" ver="2.4.2devel" ext="moodn nickn tunen buzz avatar adiumcmd"/><x xmlns="vcard-temp:x:update"><photo>57c7617952cf2ddc707153466a23da3976f2da10</photo></x></presence>
15:08:42: (Libpurple: jabber) xmlParseChunk returned error 5
15:08:42: (Libpurple: jabber) Recv (ssl)(145): <iq type="result" id="purple50a0087a" to="raeburn@mit.edu/Adiumi985" from="somebody2@mit.edu/Adium"><query xmlns="jabber:iq:last" seconds="0"/></iq>
15:08:42: (Libpurple: jabber) xmlParseChunk returned error 5
15:08:42: (Libpurple: jabber) Recv (ssl)(405): <presence from="somebody1@gmail.com/abs.mit.ed1F423CED" to="raeburn@mit.edu/Adiumi985"><show>away</show><status>My desktop computer is online.  I am not.  Please try again later...</status><c xmlns="http://jabber.org/protocol/caps" node="http://pidgin.im/caps" ver="2.4.1" ext="moodn nickn tunen avatar"/><x xmlns="vcard-temp:x:update"><photo>57c7617952cf2ddc707153466a23da3976f2da10</photo></x></presence>
15:08:42: (Libpurple: jabber) xmlParseChunk returned error 5

15:08:42: (Libpurple: jabber) Recv (ssl)(206): <iq type="result" to="raeburn@mit.edu/Adiumi985" id="purple50a00882" from="somebody3@mit.edu/Pidgin"><query xmlns="jabber:iq:version"><name>Pidgin</name><version>2.4.1 (libpurple 2.4.1)</version></query></iq>
15:08:42: (Libpurple: jabber) XML parser error for JabberStream 0x0: Domain 1, code 5, level 3: Extra content at the end of the document

15:08:42: (Libpurple: jabber) xmlParseChunk returned error 5
15:08:42: Connection Disconnected: gc=afece70 (XML Parse error)
15:08:42: <ESPurpleJabberAccount:5da6b90 11>:raeburn@mit.edu accountConnectionReportDisconnect: XML Parse error

Yes, the first one seems to have a version string with "&#16" and non-ASCII characters in it. Adium 1.3b3 logs the invalid xmlChar message, but happily continues on.

[raeburn]

And (looking at #10382) no RIGHT SINGLE QUOTATION MARK I've been able to spot in the log anywhere, if that's relevant...

[raeburn]

Ah... except for some variations in the exact failure modes, this sounds a bit like #10324. I'm seeing multiple garbage-looking non-ASCII version strings logged for contacts using Adium:

<query xmlns='jabber:iq:version'><name>Adium</name><version>ËÖ†(libpurple 2.5.0devel)</version></query>
<query xmlns="jabber:iq:version"><name>Adium</name><version>&#16;BÔøΩ&#16; (libpurple 2.4.3)</version></query>
<query xmlns="jabber:iq:version"><name>Adium</name><version>ÔøΩqÔøΩÔøΩqÔøΩÔøΩqÔøΩÔøΩqÔøΩÔøΩqÔøΩÔøΩABÔøΩ (libpurple 2.5.0devel)</version></query>

though only one has control characters in it. And the xmlChar error seems to be the first one, with xmlParseChunk reporting complaints thereafter. So, the server sends me control characters, the xml parser chokes and remembers the error state, giving me nothing else useful? Except, it looks like the fix might have been in early enough to get into 1.3b7?

[dhawes]

I think this is a side effect of the fix for:

 http://trac.adiumx.com/ticket/10353

See the comment at:

 http://developer.pidgin.im/ticket/6031#comment:9

I believe this is the same issue.

[jas8522]

Also see #10400

[evands]

I've relayed the very illustrative debug logging from this ticket to  pidgin:6031. This is indeed a dupe of #10353.