Adium

Ticket #10239 (closed defect: fixed)

Opened 21 months ago

Last modified 4 months ago

Misalignments in localised "Custom Status" windows

Reported by: jiaz1 Owned by: nobody
Milestone: Adium 1.4 Component: Adium UI
Version: 1.3b4 Severity: major
Keywords: Cc:
Patch Status:

Description

fully patched leopard with french as default language:

through adium menu bar, choose to create a personalized away message. click on any of the addition options' checkbox. note how the layout of the window text becomes grossly misaligned.

Attachments

Statuts personnalisés.jpg (32.9 KB) - added by jiaz1 21 months ago.
Statuts personnalisés.2.jpg (29.3 KB) - added by jiaz1 21 months ago.
Screenshot in New Mac Account
Custom Status.jpg (29.6 KB) - added by jiaz1 21 months ago.
Screenshot in New Mac Account--English
CustomStatusFr.png (36.2 KB) - added by biglittledragoon 21 months ago.
Problem in French (1.3ß5)
CustomStatusDe.png (36.7 KB) - added by biglittledragoon 21 months ago.
Problem in German (1.3ß5)
German.png (32.7 KB) - added by Robby 14 months ago.
English.png (29.6 KB) - added by Robby 14 months ago.
DanishWindow.jpg (184.3 KB) - added by David Munch 14 months ago.
Examples of danish window

Change History

Changed 21 months ago by jiaz1

  Changed 21 months ago by jas8522

  • status changed from new to closed
  • resolution set to worksforme

This doesn't happen for me on svn. I would guess it's either fixed for 1.3b4 OR someone needs to update the French localization in Adium. Please comment here if this is still a problem with b4 when it is released.

  Changed 21 months ago by Robby

I'm fairly certain I saw a changeset comment saying this was fixed. :)

  Changed 21 months ago by jiaz1

using 1.3b4,

the way that the layout shifts after clicking on the check-boxes has changed, but they are, nevertheless, still shifting into mis-alignment.

  Changed 21 months ago by jas8522

  • status changed from closed to reopened
  • resolution worksforme deleted
  • pending changed from 0 to 1
  • milestone set to Needs feedback from users

Could you try creating a brand new OS X user account, loading Adium in that, then reproducing this. Grab another screenshot and post it here.

Could you also try changing the language of the new OS X user account to US English and see if the problem still occurs there for you. (Make sure you do it in both French and English so we can see the difference).

  Changed 21 months ago by jas8522

  • version changed from 1.3b3 to 1.3b4

follow-up: ↓ 7   Changed 21 months ago by jiaz1

  • pending changed from 1 to 0

I created the new account and tested Adiumx in English and French. Only the French setting led to any mis-alignment.

See the new screenshots.

Changed 21 months ago by jiaz1

Screenshot in New Mac Account

Changed 21 months ago by jiaz1

Screenshot in New Mac Account--English

in reply to: ↑ 6   Changed 21 months ago by jiaz1

To clarify: I'm using 1.3b5

Replying to jiaz1:

I created the new account and tested Adiumx in English and French. Only the French setting led to any mis-alignment. See the new screenshots.

  Changed 21 months ago by evands

  • status changed from reopened to closed
  • resolution set to fixed

(In [24106]) Fixed spacing of the French custom status editing nib. Fixes #10239

  Changed 21 months ago by biglittledragoon

Hello,

there is still a problem in French in every languages I have tested.

I add a screenshot in French and in German (which isn't the worst!).

The problem is that I don't see how to change that…

Thanks,

BLD

Changed 21 months ago by biglittledragoon

Problem in French (1.3ß5)

Changed 21 months ago by biglittledragoon

Problem in German (1.3ß5)

follow-up: ↓ 12   Changed 21 months ago by evands

1.3b5 is [24103], as indicated at beta.adiumx.com. This fix was made in [24106]. It is therefore not in 1.3b5.

The problem is that the French nib's window size was changed, and its controls' positioned changed, on the vertical axis. For all other nibs, this wouldn't matter, but in this particular case the code makes certain assumptions about the window size and position to allow parts to be automatically shown or hidden.

  Changed 21 months ago by evands

(In [24108]) Fixed spacing errors in the German edit status window. Refs #10239

in reply to: ↑ 10   Changed 21 months ago by biglittledragoon

Replying to evands:

1.3b5 is [24103], as indicated at beta.adiumx.com. This fix was made in [24106]. It is therefore not in 1.3b5.

I missed that, sorry. ;-)

Replying to evands:

(In [24108]) Fixed spacing errors in the German edit status window. Refs #10239

Will it fix the other languages? Because it's the mess too…

  Changed 21 months ago by David Munch

Confirmed using danish localization. Check "Autoresponse" or "Appear away immidiately" (Quick translation from danish), and you'll see overlapping features. The problem seems to be "Save special status" not moving around in the correct way. Also, it is positioned wrongly when you open the window (At leasst here in danish, is that something I should fix?)

follow-up: ↓ 15   Changed 21 months ago by evands

I don't understand why these layouts are all different from the English one. The best thing to do is to tell iLocalize to reset the layout to the English one, then resize your controls as needed.

in reply to: ↑ 14   Changed 21 months ago by biglittledragoon

Replying to evands:

I don't understand why these layouts are all different from the English one.

We recently added an option for Growl, right? It might come from that…

Replying to evands:

The best thing to do is to tell iLocalize to reset the layout to the English one, then resize your controls as needed.

It's done! :P

  Changed 21 months ago by Robby

  • milestone changed from Needs feedback from users to SVN issues

  Changed 18 months ago by biglittledragoon

If I rebuild from English, I have this message:

[09/25/2008 16:56:57] 2008-09-25 16:56:56.932 nibtool[2283] **** verification error ****: <NSCustomObject: 0x388200> has an invalid object id -3 (must be < 132)
2008-09-25 16:56:57.000 nibtool[2283] **** verification error ****: <NSCustomObject: 0x388200> has an invalid object id -3 (must be < 132)

  Changed 14 months ago by Robby

Any news on this, BLD?

  Changed 14 months ago by biglittledragoon

Excepted this error when I rebuilt, it looks to be OK now (1.3.2). Users reported it too.
I hadn't the time to check this in the last ß, but it should be OK.

  Changed 14 months ago by Robby

Ok, good. :)

  Changed 14 months ago by David Munch

I reset it from english for the 1.3 version I believe, yet, the problem has reappeared.. At least I see it for 1.3.3b1 using danish.

  Changed 14 months ago by Robby

  • status changed from closed to reopened
  • severity changed from normal to trivial
  • summary changed from personalized away message window to Misalignments in localised "Custom Status" windows (left: Danish)
  • priority changed from normal to lowest
  • milestone changed from SVN issues to Adium 1.3.3
  • resolution fixed deleted

Could you add a screenshot, David?

  Changed 14 months ago by Robby

  • summary changed from Misalignments in localised "Custom Status" windows (left: Danish) to Misalignments in localised "Custom Status" windows (remaining: Danish)

  Changed 14 months ago by Robby

  • summary changed from Misalignments in localised "Custom Status" windows (remaining: Danish) to Misalignments in localised "Custom Status" windows

Ok, I have to add that there are also issues with German (still) and English.

  • German: "Title" (too far right), "State" and "Status Message" (both too far left) are incorrectly aligned.
  • English: The bottom four checkboxes are a little too far right.

See screenshots "German" and "English" for reference.

Changed 14 months ago by Robby

Changed 14 months ago by Robby

  Changed 14 months ago by David Munch

As far as I can see, there are two issues:

  • The last checkbox is positioned wrongly when the window is opened.
  • The two top checkboxes fuck up the view, with regards to the last checkbox.

Checking the two checkboxes with Growl and sounds turning off, the view is fixed! I hope these observations would help. Image attached.

Changed 14 months ago by David Munch

Examples of danish window

  Changed 13 months ago by Robby

  • milestone changed from Adium 1.3.3 to Adium 1.3.4

  Changed 10 months ago by jas8522

  • milestone changed from Adium 1.3.4 to Adium 1.4 (Release)

  Changed 5 months ago by zacw

  • milestone changed from Adium 1.4 (Release) to Adium 1.4

  Changed 4 months ago by zacw

  • milestone changed from Adium 1.4 to Adium 1.4.x

If these are still a problem in 1.4, I believe it is due to the nib's controls not being linked properly, probably due to localization copy/pasting the field, or something like that.

Please report this on a language-by-language basis against a 1.4-final localization set.

  Changed 4 months ago by David Munch

Stil a problem in the danish localization, as per 1.4b15.

  Changed 4 months ago by zacw

  • severity changed from minor to major
  • milestone changed from Adium 1.4.x to Adium 1.4

Okay then, let's take a deeper look.

  Changed 4 months ago by Zachary West <zacw@…>

  • status changed from new to closed
  • resolution set to fixed

(In  32fc37922daf) Fix a bunch of localizations specifying an autoresizing mask for the "save state" button in the custom status window, breaking the layout. Fixes #10239.

  Changed 4 months ago by Evan Schoenberg

(In  4d3a8b7c1cf4) FIxed all springs and struts on EditStateSheet nibs. Fixes #10239.

  Changed 4 months ago by Evan Schoenberg

(In  501511e20df4) Corrected an off-by-1-pixel alignment problem with the last 4 checkboxes of the status window, pointed out by Robby in #10239. Refs #10239 (whose core issue is already fixed).

Note: See TracTickets for help on using tickets.