Ticket #10174 (closed defect: fixed)
%status% shouldn't contain "history"
| Reported by: | mathuaerknedam | Owned by: | |
|---|---|---|---|
| Milestone: | Adium 1.3.3 | Component: | Message View |
| Version: | 1.3svn | Severity: | regression |
| Keywords: | Cc: | Catfish_Man | |
| Patch Status: |
Description
As of r24019...
Date separators in message history return a %status% of "date_separator history", but history isn't really part of the status. As far as I can tell, date separators are the only type of status or event that appears in message history, so this is probably the only place where "history" appears incorrectly.
Change History
comment:3 Changed 4 years ago by evands
- Status changed from new to closed
- Resolution set to wontfix
It -is- a historical date separator, though, and if you are controlling the display of all history (e.g. fading it relative to current messages) you want to be able to fade the date separator appropriately, too.
comment:5 Changed 4 years ago by mathuaerknedam
- Status changed from closed to reopened
- Resolution wontfix deleted
I think you might be confusing %status% with %messageclasses%. After you closed the ticket I reread this and couldn't figure out why I had opened it. Alternative, I may be misunderstanding the use of %status%.
%messageclasses% does correctly contain date_seperator and history, and gets used exactly as you suggest. As I understand it %status% is available only in status.html and is used to determine exactly what type of status message is being displayed. This is they way it's use is described in #CreatingMessageStyles. "history" is not a type of status message, it's a class that some status messages might have (like they used to have the class "incoming").
comment:8 Changed 3 years ago by Robby
- Milestone changed from Adium bugs to Adium 1.3.3
As it's a regression...
comment:9 Changed 3 years ago by evands
- Status changed from reopened to closed
- Resolution set to fixed
(In [25698]) Don't include 'history' in the %status% of a date separator in history; this should instead be included as a display class. Fixes #10174
comment:10 Changed 3 years ago by evands
(In [25699]) Merged [25698]: Don't include 'history' in the %status% of a date separator in history; this should instead be included as a display class. Fixes #10174