%status% shouldn't contain "history"

[mathuaerknedam]

As of r24019...

Date separators in message history return a %status% of "date_separator history", but history isn't really part of the status. As far as I can tell, date separators are the only type of status or event that appears in message history, so this is probably the only place where "history" appears incorrectly.

[evands]

It -is- a historical date separator, though, and if you are controlling the display of all history (e.g. fading it relative to current messages) you want to be able to fade the date separator appropriately, too.

[mathuaerknedam]

I think you might be confusing %status% with %messageclasses%. After you closed the ticket I reread this and couldn't figure out why I had opened it. Alternative, I may be misunderstanding the use of %status%.

%messageclasses% does correctly contain date_seperator and history, and gets used exactly as you suggest. As I understand it %status% is available only in status.html and is used to determine exactly what type of status message is being displayed. This is they way it's use is described in #CreatingMessageStyles. "history" is not a type of status message, it's a class that some status messages might have (like they used to have the class "incoming").

[Robby]

As it's a regression...

[evands]

(In [25698]) Don't include 'history' in the %status% of a date separator in history; this should instead be included as a display class. Fixes #10174

[evands]

(In [25699]) Merged [25698]: Don't include 'history' in the %status% of a date separator in history; this should instead be included as a display class. Fixes #10174