wrong messageclasses on notifications

[mathuaerknedam]

I'm pretty sure this used to be correct, but as of r24008, 1.3b2 and 1.2.5 the messageclasses on incoming notifications (BUZZ!) is incorrect. Incoming is now "libpurplemessage event" and outgoing is "outgoing message notification". The specific messageclasses are different for 1.2.5 because the messageclasses spec were intentionally changes for 1.3, but I've verified with CFM that this wasn't part of the intentional changes.

[jas8522]

Placing a bit later, since this is not a 1.3 regression.

[evands]

This was the case for Jabber buzzes only, the result of a libpurple mistake which I fixed in [f94ddf7fa975e3a39a53fccae31b7e73f892fd57] for libpurple 2.5.4.

[mathuaerknedam]

I thought I had seen this in Yahoo too, but sure enough, Yahoo doesn't get classed with "libpurplemessage". However, Now that I've tested both, I can see another difference in the behaviors between yahoo and jabber. With jabber, the outgoing message is a message and the incoming message is an event. With yahoo, they are both messages. I'd think they should both be events (even though neither one does this currently) or at least be consistent across protocols. Does your libpurple fix address this too?

[evands]

The fix will make them uniform... we can now consider how best to display the uniform information. I agree that it's more an event than a message... could you please make a ticket for displaying incoming and outgoing buzz-style notifications as events?

[mathuaerknedam]

Cool. It's #11528.

[mathuaerknedam]

Evan, think your change might also resolve #11333?

[mathuaerknedam]

Replying to mathuaerknedam:

Evan, think your change might also resolve #11333?

It does not.