Adium

Ticket #10074 (closed defect: fixed)

Opened 21 months ago

Last modified 17 months ago

Contact list toolbar overlaps a few pixels of the contact list content

Reported by: sengelking Owned by: zacw
Milestone: Adium 1.3.2 Component: Adium Core
Version: 1.3b3 Severity: regression
Keywords: Cc:
Patch Status:

Description

Nit-picky issue, but after installing the latest version of Adium 1.3b2 today, the top field in the buddy list is incorrectly spaced too high.

Love the program!

Sean

Attachments

Picture 1.png (55.1 KB) - added by sengelking 21 months ago.
See spacing for AL272727
white stripe over groups.png (62.8 KB) - added by Melebius 17 months ago.

Change History

Changed 21 months ago by sengelking

See spacing for AL272727

Changed 21 months ago by Robby

  • owner changed from nobody to zacw
  • priority changed from normal to low
  • version changed from 1.2.5 to 1.3b2
  • severity changed from normal to regression
  • milestone set to Adium X 1.3

Changed 21 months ago by jas8522

  • version changed from 1.3b2 to 1.3b3

I can reproduce this with 1.3b3 @ OS X 10.5.3 - steps to reproduce are as simple as View > Hide Groups

Changed 21 months ago by Robby

Actually, this also affects groups. One or two pixels are just cut off the top.

Changed 21 months ago by jas8522

  • summary changed from Buddy list spacing issue with Adium 1.3b2 to Contact list toolbar overlaps a few pixels of the contact list content

Changed 21 months ago by zacw

There's a lot of areas of code where there's off-by-one-pixel problems in the contact list. I'm going to go through and try and set it all correctly.

Changed 20 months ago by evands

Any luck, Zac?

Changed 20 months ago by zacw

I think we're setting the location too high, and were compensating that by calculating the height correctly, but continuing to position wrong. That's why an extra pixel of space pops up when contacts sign on/off, etc. I haven't had a chance to go through and fix it. I think my fix to correct the pixel of blank space at the bottom of the contact list was wrong: the solution was probably to shift the contact list back into the right position.

Changed 20 months ago by jas8522

  • milestone changed from Adium X 1.3 to Adium X 1.3.1

Due to the non-urgency of this, it may as well wait for 1.3.1...

Changed 19 months ago by jas8522

  • milestone changed from Adium 1.3.1 to Adium 1.3.3

Changed 19 months ago by cbarrett

  • milestone changed from Adium 1.3.3 to Adium 1.4

Changed 19 months ago by evands

  • milestone changed from Adium 1.4 to Adium 1.3.3

This is a 1.3 regression, probably from the contact list search bar. I'd prefer to continue to target 1.3.x, and I think regressions shouldn't be tolerated.

Changed 18 months ago by zacw

  • status changed from new to closed
  • resolution set to fixed

(In [25143]) Move the origin of the contact list view up by 1, and increase its vertical padding by 1. This, somehow, fixes #10074. I'm at a loss for words how it does it, or what code was assuming it worked this way, but my brain hurts too much to try and figure out any more. There's still an off-by-1 error in height when animations are taking place; I'm not able to track that down either.

Changed 18 months ago by zacw

(In [25144]) Merged [25143]: Move the origin of the contact list view up by 1, and increase its vertical padding by 1. This, somehow, fixes #10074. svn is also pushing a lot of property changes so I say, what the hey, why not; it's your party, you can cry if you want to, svn.

Changed 18 months ago by zacw

  • milestone changed from Adium 1.3.3 to Adium 1.3.2

Changed 17 months ago by Melebius

Changed 17 months ago by Melebius

After installing 1.3.2, a white stripe started to appear over the first group in my buddy list (picture “white stripe over groups.png”) and I think it has something to do with changes described above.

Changed 17 months ago by Robby

That's #11119.

Note: See TracTickets for help on using tickets.